Connect data-selector to tf-tensorboard #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the data flows properly from the data-selector to the plugins that uses the data selector.
nfelt
approved these changes
Jul 26, 2018
| @@ -715,6 +717,15 @@ <h3>There’s no dashboard by the name of “<tt>[[_selectedDashboard]]</tt>.” | |||
| return dashboard; | |||
| }, | |||
|
|
|||
| _updateDataSelection() { | |||
There was a problem hiding this comment.
Just so I understand, this observer is necessary because Polymer doesn't have enough context to automatically propagate the data selection from the tf-tensorboard _dataSelection property into the stamped dashboard element binding? I wonder if there's any way to explicitly tell Polymer to do that for us....
...it looks like probably not: Polymer/polymer#1778 (comment)
There was a problem hiding this comment.
Yup, that was my intention. I technically don't need two-way binding since I don't need the upward directionality. For now, I thought, the code is clean enough as is. Let me know if you are okay with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the data flows properly from the data-selector to the plugins
that uses the data selector.