Fix custom_scalar displaying duplicated charts #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
Jul 18, 2018
| @@ -92,6 +92,11 @@ def __init__(self, *args, **kwargs): | |||
| upper='cross entropy upper'), | |||
| ], | |||
| )), | |||
| layout_pb2.Chart( | |||
There was a problem hiding this comment.
Maybe extend the comment on line 81 to say "and contains a duplicate chart also in that run" or something?
| @@ -276,7 +276,10 @@ def layout_impl(self): | |||
| if category.title in title_to_category: | |||
| # A category with this name has been seen before. Do not create a | |||
| # new one. Merge their charts. | |||
There was a problem hiding this comment.
Could you extend the comment here to say "Merge their charts, skipping any duplicates."?
lgeiger
force-pushed
the
fix-custom-scalar-duplicates
branch
from
06b262f
to
efd6edd
Compare
|
@nfelt Thanks for the fast review. I added the suggested comment to make the change clearer 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple runs with the same custom scalar layout, tensorboard will duplicate the charts for every run.
This PR fixes the problem by deduplicating the charts before adding them to the category.