Prevent content from intruding into sidebar #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within small viewports, main content had been overlapping with the sidebar. This change fixes that by removing a `min-width` specification on the wrong container and placing it on the right one.
nfelt
approved these changes
Feb 28, 2018
|
Yeah, having 2 containers named sidebar (one in the other) is indeed confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within small viewports, main content had been overlapping with the
sidebar.
This change fixes that by removing a
min-widthspecification on thewrong container and placing it on the right one. Changed that min width
to 270px (from 350px). Any lower, and buttons overflow to the next line.
New behavior: