Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh Plugin: slider has 3x more steps than required #2270

Closed
podlipensky opened this issue May 22, 2019 · 0 comments · Fixed by #2306
Closed

Mesh Plugin: slider has 3x more steps than required #2270

podlipensky opened this issue May 22, 2019 · 0 comments · Fixed by #2306
Assignees
@podlipensky
Labels
plugin:mesh type:bug

Comments

@podlipensky
Copy link
Contributor

Looks like total count of steps in the mesh plugin is miscalculated because of internal representation of the mesh.
@abhinavsagar abhinavsagar mentioned this issue May 27, 2019
Closed
wchargin added a commit that referenced this issue Jun 4, 2019
@wchargin
mesh: fix steps slider
5c72b4e 
Summary:
The steps slider was supposed to be capped at the number of steps, but
in fact was always capped at 100 due to a typo in the Polymer binding.
Fixes #2270.

Test Plan:
Check out #2265 and run the mesh demo to generate test data. Then,
launch TensorBoard with the mesh data and observe that the slider now
goes from 0 to 9 instead of 0 to 100, and that moving along the entire
range of the slider is now useful.

wchargin-branch: mesh-fix-steps
@wchargin wchargin mentioned this issue Jun 4, 2019
Merged
wchargin added a commit that referenced this issue Jun 5, 2019
@wchargin
mesh: fix steps slider (#2306)
96efde4 
Summary:
The steps slider was supposed to be capped at the number of steps, but
in fact was always capped at 100 due to a typo in the Polymer binding.
Fixes #2270.

Test Plan:
Check out #2265 and run the mesh demo to generate test data. Then,
launch TensorBoard with the mesh data and observe that the slider now
goes from 0 to 9 instead of 0 to 100, and that moving along the entire
range of the slider is now useful.

wchargin-branch: mesh-fix-steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@podlipensky podlipensky

Labels
plugin:mesh type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mesh: fix steps slider tensorflow/tensorboard
2 participants
@podlipensky @wchargin