Embedding Projector: fix switching projections

tensorflow · Apr 4, 2023 · cb0e399 · cb0e399
1 parent e5d1771
commit cb0e399
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/tensorboard/plugins/projector/vz_projector/vz-projector-projections-panel.ts b/tensorboard/plugins/projector/vz_projector/vz-projector-projections-panel.ts
@@ -399,7 +399,6 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) {
       this.searchByMetadataOptions[Math.max(0, searchByMetadataIndex)];
   }
   public showTab(id: ProjectionType) {
-    this.currentProjection = id;
     const tab = this.$$('.ink-tab[data-tab="' + id + '"]') as HTMLElement;
     const allTabs = this.root?.querySelectorAll('.ink-tab');
     if (allTabs) {
@@ -434,19 +433,23 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) {
     if (this.polymerChangesTriggerReprojection === false) {
       return;
     }
-    if (projection === 'pca') {
+    if (this.currentProjection !== projection) {
+      this.currentProjection = projection;
       if (this.dataSet != null) {
-        this.dataSet.stopTSNE();
+        if (projection === 'tsne') {
+          this.dataSet.tSNEShouldPause = false;
+        } else {
+          this.dataSet.tSNEShouldPause = true;
+        }
       }
+    }
+    if (projection === 'pca') {
       this.showPCA();
     } else if (projection === 'tsne') {
       this.showTSNE();
     } else if (projection === 'umap') {
       this.showUmap();
     } else if (projection === 'custom') {
-      if (this.dataSet != null) {
-        this.dataSet.stopTSNE();
-      }
       this.computeAllCentroids();
       this.reprojectCustom();
     }
@@ -489,6 +492,7 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) {
       (iteration: number) => {
         if (iteration != null) {
           this.runTsneButton.disabled = false;
+          this.pauseTsneButton.innerText = 'Pause';
           this.pauseTsneButton.disabled = false;
           this.iterationLabelTsne.innerText = '' + iteration;
           this.projector.notifyProjectionPositionsUpdated();