Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Conversation

@phamthuonghai
Copy link
Contributor

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author has not signed CLA label Jun 27, 2019
@phamthuonghai
Copy link
Contributor Author

Done CLA

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has signed CLA and removed cla: no PR author has not signed CLA labels Jun 27, 2019
@phamthuonghai phamthuonghai changed the title Should not generate summary during decoding in dot_product_relative_atention Should not generate summary during decoding in dot_product_relative_attention Jun 27, 2019
Copy link
Contributor

@lukaszkaiser lukaszkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@lukaszkaiser lukaszkaiser merged commit 21394f1 into tensorflow:master Jul 18, 2019
@lukaszkaiser
Copy link
Contributor

Very helpful, thanks!

tensorflow-copybara pushed a commit that referenced this pull request Jul 18, 2019
PiperOrigin-RevId: 258829641
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants