This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Updated ResNet to work with 2019-06-04 development snapshot. #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoxzhao
commented
Jun 6, 2019
| data = Tensor<Float>(handle: TensorHandle<Float>(handle: _handles[dataIndex])) | ||
| } | ||
|
|
||
| //public var _tensorHandles: [_AnyTensorHandle] { [label.handle.handle, data.handle.handle] } |
Contributor
Author
There was a problem hiding this comment.
I feel this is a bug, but not entirely sure. How else to satisfy TensorGroup protocol?
Contributor
There was a problem hiding this comment.
This is a known regression introduced in tensorflow/swift-apis#165 and should be fixed soon. You can look at test cases in that PR to see how they satisfied the requirements.
Contributor
Author
|
I have incorporated this change into #166 so that one PR updates all models. Close this PR. |
Contributor
|
Sounds good! |
pschuh
pushed a commit
to pschuh/swift-models
that referenced
this pull request
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #165.