This repository was archived by the owner on Jul 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 136
Add–1d–layers #57
Merged
The head ref may contain hidden characters: "add\u20131d\u2013layers"
Merged
Add–1d–layers #57
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
82797fd
Added Conv1d, MaxPool1D and AvgPool1D layers
74fa216
Fixed input dimensions
1df460a
Fixed filter dimension; added tests
c8b7e73
Update Sources/DeepLearning/Layer.swift
dan-zheng 827a185
Comments and spacing issue fixes
deb771b
more indentation fixes
a76891d
Update Sources/DeepLearning/Layer.swift
rxwei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright 2019 The TensorFlow Authors. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import XCTest | ||
| @testable import DeepLearning | ||
|
|
||
| final class LayerTests: XCTestCase { | ||
| func testConv1D() { | ||
| let filter = Tensor<Float>(ones: [3, 1, 2]) * Tensor<Float>([[[0.33333333, 1]]]) | ||
| let bias = Tensor<Float>([0, 1]) | ||
| let layer = Conv1D<Float>(filter: filter, bias: bias, activation: identity, stride: 1, padding: .valid) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fit within 100 columns. |
||
| let input = Tensor<Float>([[0, 1, 2, 3, 4], [10, 11, 12, 13, 14]]).expandingShape(at: 2) | ||
| let output = layer.inferring(from: input) | ||
| let expected = Tensor<Float>([[[1, 4], [2, 7], [3, 10]], [[11, 34], [12, 37], [13, 40]]]) | ||
| XCTAssertEqual(round(output), expected) | ||
| } | ||
|
|
||
| func testMaxPool1D() { | ||
| let layer = MaxPool1D<Float>(poolSize: 3, stride: 1, padding: .valid) | ||
| let input = Tensor<Float>([[0, 1, 2, 3, 4], [10, 11, 12, 13, 14]]).expandingShape(at: 2) | ||
| let output = layer.inferring(from: input) | ||
| let expected = Tensor<Float>([[[2], [3], [4]], [[12], [13], [14]]]) | ||
| XCTAssertEqual(round(output), expected) | ||
| } | ||
|
|
||
| func testAvgPool1D() { | ||
| let layer = AvgPool1D<Float>(poolSize: 3, stride: 1, padding: .valid) | ||
| let input = Tensor<Float>([[0, 1, 2, 3, 4], [10, 11, 12, 13, 14]]).expandingShape(at: 2) | ||
| let output = layer.inferring(from: input) | ||
| let expected = Tensor<Float>([[[1], [2], [3]], [[11], [12], [13]]]) | ||
| XCTAssertEqual(round(output), expected) | ||
| } | ||
|
|
||
| static var allTests = [ | ||
| ("testConv1D", testConv1D), ("testMaxPool1D", testMaxPool1D), ("testAvgPool1D", testAvgPool1D) | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using
identityas the default activation inDenseandConv2D.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The init method in the struct declaration doesn't have a default. Only the ones in the extensions have default values. So this is consistent, but maybe not what is desired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you are right!