Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Conversation

@vvmnnnkv
Copy link
Contributor

Makes Tensor.padded() on par with tf.pad().
Added padding modes (reflect, symmetric) can be used to make "resize-convolution" layers like in tensorflow/swift-models#191.

@rxwei rxwei requested review from eaplatanios and rxwei September 24, 2019 16:11
Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@vvmnnnkv vvmnnnkv requested a review from rxwei September 29, 2019 17:53
internal extension Tensor where Scalar: TensorFlowFloatingPoint {
@inlinable
func _vjpPadded(
func _vjpPaddedWithMode(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The “WithMode” suffix is unnecessary. Swift accepts overloads.

@rxwei rxwei merged commit e63cd23 into tensorflow:master Oct 1, 2019
ocampor pushed a commit to ocampor/swift-apis that referenced this pull request Oct 4, 2019
Makes Tensor.padded() on par with tf.pad().
Added padding modes (reflect, symmetric) can be used to make "resize-convolution" layers like in tensorflow/swift-models#191.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants