This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Port over tensor_autodiff_runtime.swift tests.
#235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartchr808
commented
Jun 13, 2019
bgogul
reviewed
Jun 13, 2019
Contributor
bgogul
left a comment
bgogul
left a comment
There was a problem hiding this comment.
Thanks @bartchr808. Can you name the tests appropriately?
Contributor
Author
|
@bgogul quick ping for a re-review 😄 |
rxwei
reviewed
Jun 14, 2019
bgogul
approved these changes
Jun 14, 2019
Contributor
bgogul
left a comment
bgogul
left a comment
There was a problem hiding this comment.
Looks good. Just address Richard's comments?
| func foo(tensor: Tensor<Float>, shape: Tensor<Int32>) -> Tensor<Float> { | ||
| tensor.unbroadcasted(toShape: shape) | ||
| } | ||
| var inputTensor: Tensor<Float> |
Contributor
There was a problem hiding this comment.
Is there any reason for the initialization to be an a different line?
Contributor
Author
There was a problem hiding this comment.
I can initialize it to the one needed for the first subtest.
dan12411
pushed a commit
to dan12411/swift-apis
that referenced
this pull request
Jun 15, 2019
- Port over tensor_autodiff_runtime.swift tests from apple/swift PR 24899.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports over the tests that were located here in
apple/swiftbefore the refactor. Not all of them were ported over, as seen in the PR here, and this PR only adds the ones inTensorFlowRuntime/tensor_autodiff_runtime.swiftand also the ones I was going to add for testingbroadcast/unbroadcastin this PR.