Tensorflow 2.0 support

[r-wheeler]

Thanks for the excellent bindings, we have had great success using them. Do you know when tensorflow 2 saved models will be supported?

I have inquired in other channels about the stability of the tensorflow 2.0 C API but not gotten a response.

[Arnold1]

hi @r-wheeler is tensorflow 2.0 C API already released?

[claytoncasey01]

hi @r-wheeler is tensorflow 2.0 C API already released?

The C++ API for tensorflow core is currently at 2.2.0.

[kykosic]

The C++ core is different than the C lib. Per the docs, libtensorflow C 2.0+ isn't expected until core 2.3.

In the meantime, some beta work could be done using the nightly builds, which currently are on 2.2.0. I've been able to compile and run tests against these with no issues.

[r-wheeler]

Thanks @kykosic The last time I had looked at the C lib it had not yet specified a release. I believe I saw an announcement that 2.3 would bet cut on 6/22.

I would love to be able to jump in and contribute to this project. Any good starting points to help with a 2.x version of these bindings?

[Arnold1]

is there a big change planned for 2.3 - or why they release a new c lib with 2.3?

[kykosic]

I don't see anything big on the project page https://github.com/orgs/tensorflow/projects/9 (or anything mentioning the C API). It seems that the C API was just not prioritized with the TF2.0 release, but the few comments from internal devs have repeated that they plan to have it back by with the 2.3 release. According to the mailing list, the branch should have been cut yesterday https://groups.google.com/a/tensorflow.org/forum/#!topic/developers/u1eTZtaAxwo

[kykosic]

TF 2.3 was released yesterday, and it looks like the 2.3 C lib has been published along with it https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-linux-x86_64-2.3.0.tar.gz

[DouglasLivingstone]

From the history of c_api.h it looks like there have been some breaking changes, this commit removed TF_StringEncode and TF_StringDecode, so bindgen.rs would need to be updated.

[klotzambein]

I just tried to naively update to the new version and ran all tests. This only breaks the test_library_load test with this error:

thread 'tests::test_library_load' panicked at 'called `Result::unwrap()` on an `Err` value: {inner:0x7f922000c460, NotFound: libtensorflow_framework.so.1: cannot open shared object file: No such file or directory}', src/lib.rs:2319:23

I changed the version in tensorflow-sys and in run-valgrind.

[kahlil29]

Now that TF2.3 is released with the C Lib, is there a lot of more work to be done before we can achieve Tensorflow 2 support?

[adamcrume]

I'm working on the upgrade, but I'm running into segfaults, so it's probably not going to be quick and easy.

[kahlil29]

Thanks for the update! Let me know if I can help in any way :)

…

On Fri, 2 Oct, 2020, 10:56 am Adam Crume, ***@***.***> wrote: I'm working on the upgrade, but I'm running into segfaults, so it's probably not going to be quick and easy. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#252 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6CJ3PN3OORSFXXSKDTQVDSIU6MZANCNFSM4M2OS7XQ> .

[tallamjr]

Me too, I would love to help where possible, but would need some guidance on where to start.

The docs for extending to other language bindings seems to be out-of-date? Or at least it is filed away under a directory specific for TF1 guides according to this commit

Does anyone know how one could get going on this, or perhaps where in general one could learn about extending the bindings to rust?

Disclaimer, I am very new to rust, but this project really excites me and happy to throw myself in the deep end to help!

Thanks @kykosic The last time I had looked at the C lib it had not yet specified a release. I believe I saw an announcement that 2.3 would bet cut on 6/22.

I would love to be able to jump in and contribute to this project. Any good starting points to help with a 2.x version of these bindings?