Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new noise tutorial. #582

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Added new noise tutorial. #582

merged 5 commits into from
Jun 10, 2021

Conversation

MichaelBroughton
Copy link
Collaborator

Fixes #573 .

Revamps the noise tutorial found in #454 to make use of new noisy features found in tfq.layers and tfq.noise. What do people think ?

@zaqqwerty , @jaeyoo and @lamberta .

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@MichaelBroughton MichaelBroughton mentioned this pull request Jun 3, 2021
Closed
jaeyoo
jaeyoo reviewed Jun 9, 2021
View reviewed changes
docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is reffered to as the --> is referred to as the

a simplifying assumption you can make -> a simple assumption you can make


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Line #2.      """Produce a a circuit on qubits."""

Produces a circuit


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latex is totally broken from \rhos to the end. it seems missing $ somewhere


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concetrating -> concentrating

Doing ... are -> Doing ... is


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reffered -> referred


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contiaining -> containing


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Line #5.      ret += cirq.H.on_each(*qubits)

is this really working? what about ret += cirq.Circuit(cirq.H.on_each(*qubits)


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly the same with the above except the value of depolarize_p. this could be a helper function.


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly the same with the above. this could be a helper function.


Reply via ReviewNB

docs/tutorials/noise.ipynb
@@ -0,0 +1,790 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly the same with the above. this could be a helper function.


Reply via ReviewNB

jaeyoo
jaeyoo previously approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@jaeyoo jaeyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, glad to see tfdocs.plots!

@MichaelBroughton MichaelBroughton merged commit 19dbae5 into master Jun 10, 2021
@MichaelBroughton MichaelBroughton deleted the noise_tutorial branch June 10, 2021 02:27
jaeyoo pushed a commit to jaeyoo/quantum that referenced this pull request Mar 30, 2023
@sergeisakov
Merge pull request tensorflow#582 from quantumlib/small-input-vector-2
d78a61f 
Fix array overflow for small input vectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeyoo jaeyoo jaeyoo left review comments

@lamberta lamberta Awaiting requested review from lamberta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New noise tutorial
2 participants
@MichaelBroughton @jaeyoo