Skip to content
This repository was archived by the owner on Sep 27, 2024. It is now read-only.

Consolidate testdata and delete unused output files #255

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Consolidate testdata and delete unused output files #255

merged 1 commit into from
Dec 16, 2022

Conversation

codesue
Copy link
Contributor

@codesue codesue commented Dec 3, 2022

What does this pull request do?

  • Moves test data in template/test to utils/testdata
  • Deletes unused rendered model card outputs, which also don't seem to be updated when templates are updated

How did you test this change?

Applied changes in #254 and ran pytest model_card_toolkit.

How did you document this change?

N/A

Before submitting

Before submitting a pull request, please be sure to do the following:

  • Read the How to Contribute guide if this is your first contribution.
  • Open an issue or discussion topic to discuss this change.
  • Write new tests if applicable.
  • Update documentation if applicable.

@codesue
Copy link
Contributor Author

codesue commented Dec 16, 2022

Hi @casassg, @deutranium, or @hanneshapke, would you please review this when you get a chance. 🙏

Copy link

@deutranium deutranium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you for contributing!!

@codesue codesue merged commit 894d0c4 into tensorflow:master Dec 16, 2022
@codesue codesue deleted the codesue/consolidate-testdata branch December 16, 2022 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants