Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test workflow with unittest #189

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# Github action definitions for unit-tests with PRs.

name: tfma-unit-tests
on:
push:
pull_request:
branches: [ master ]
paths-ignore:
- '**.md'
- 'docs/**'
workflow_dispatch:

jobs:
unit-tests:
if: github.actor != 'copybara-service[bot]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we skip this on this bot?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing workflow was configured this way for TFX, and I copied it here.

If we can justify removing that condition, I'm happy to do so.

@embr do you have an opinion here?

runs-on: ubuntu-latest

strategy:
matrix:
python-version: ['3.9', '3.10']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at README.md looks like 3.11 is also supported?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely remember an issue with 3.11. I just added it, so we'll see what happens

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing probably because 3.11 would require different version of protobuf-compiler, similar to the different versions of library specified here:

'protobuf>=3.20.3,<5;python_version<"3.11"',

but, either ways it's okay to skip 3.11 in this PR and can be handled later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okay to skip 3.11 in this PR and can be handled later.

I'd rather do this than try to make 3.11 work in this PR


steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: 'pip'
cache-dependency-path: |
setup.py

- name: Install dependencies
run: |
sudo apt update
sudo apt install protobuf-compiler -y
pip install .

- name: Run unit tests
shell: bash
run: |
python -m unittest discover -p "*_test.py"
162 changes: 162 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,162 @@
# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
*$py.class

# C extensions
*.so

# Distribution / packaging
.Python
build/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
wheels/
share/python-wheels/
*.egg-info/
.installed.cfg
*.egg
MANIFEST

# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec

# Installer logs
pip-log.txt
pip-delete-this-directory.txt

# Unit test / coverage reports
htmlcov/
.tox/
.nox/
.coverage
.coverage.*
.cache
nosetests.xml
coverage.xml
*.cover
*.py,cover
.hypothesis/
.pytest_cache/
cover/

# Translations
*.mo
*.pot

# Django stuff:
*.log
local_settings.py
db.sqlite3
db.sqlite3-journal

# Flask stuff:
instance/
.webassets-cache

# Scrapy stuff:
.scrapy

# Sphinx documentation
docs/_build/

# PyBuilder
.pybuilder/
target/

# Jupyter Notebook
.ipynb_checkpoints

# IPython
profile_default/
ipython_config.py

# pyenv
# For a library or package, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
# .python-version

# pipenv
# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control.
# However, in case of collaboration, if having platform-specific dependencies or dependencies
# having no cross-platform support, pipenv may install dependencies that don't work, or not
# install all needed dependencies.
#Pipfile.lock

# poetry
# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control.
# This is especially recommended for binary packages to ensure reproducibility, and is more
# commonly ignored for libraries.
# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control
#poetry.lock

# pdm
# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control.
#pdm.lock
# pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it
# in version control.
# https://pdm.fming.dev/latest/usage/project/#working-with-version-control
.pdm.toml
.pdm-python
.pdm-build/

# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm
__pypackages__/

# Celery stuff
celerybeat-schedule
celerybeat.pid

# SageMath parsed files
*.sage.py

# Environments
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/

# Spyder project settings
.spyderproject
.spyproject

# Rope project settings
.ropeproject

# mkdocs documentation
/site

# mypy
.mypy_cache/
.dmypy.json
dmypy.json

# Pyre type checker
.pyre/

# pytype static type analyzer
.pytype/

# Cython debug symbols
cython_debug/

# PyCharm
# JetBrains specific template is maintained in a separate JetBrains.gitignore that can
# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
# and can be added to the global gitignore or merged into this file. For a more nuclear
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
#.idea/
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ cd dist
pip3 install tensorflow_model_analysis-<version>-py3-none-any.whl
```

### Running tests

To run tests, run

```
python -m unittest discover -p *_test.py
```

from the root project directory.

### Jupyter Lab

As of writing, because of https://github.com/pypa/pip/issues/9187, `pip install`
Expand Down
9 changes: 9 additions & 0 deletions tensorflow_model_analysis/api/model_eval_lib_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import json
import os
import tempfile
import unittest

from absl.testing import absltest
from absl.testing import parameterized
Expand Down Expand Up @@ -1122,6 +1123,8 @@ def testRunModelAnalysisWithQueryBasedMetrics(self):
for k in expected_metrics[group]:
self.assertIn(k, got_metrics[group])

# PR 189: Remove the `expectedFailure` mark if the test passes
@unittest.expectedFailure
def testRunModelAnalysisWithUncertainty(self):
examples = [
self._makeExample(age=3.0, language='english', label=1.0),
Expand Down Expand Up @@ -1391,6 +1394,8 @@ def testRunModelAnalysisWithSchema(self):
self.assertEqual(1.0, got_buckets[1]['lowerThresholdInclusive'])
self.assertEqual(2.0, got_buckets[-2]['upperThresholdExclusive'])

# PR 189: Remove the `expectedFailure` mark if the test passes
@unittest.expectedFailure
def testLoadValidationResult(self):
result = validation_result_pb2.ValidationResult(validation_ok=True)
path = os.path.join(absltest.get_default_test_tmpdir(), 'results.tfrecord')
Expand All @@ -1399,6 +1404,8 @@ def testLoadValidationResult(self):
loaded_result = model_eval_lib.load_validation_result(path)
self.assertTrue(loaded_result.validation_ok)

# PR 189: Remove the `expectedFailure` mark if the test passes
@unittest.expectedFailure
def testLoadValidationResultDir(self):
result = validation_result_pb2.ValidationResult(validation_ok=True)
path = os.path.join(
Expand All @@ -1409,6 +1416,8 @@ def testLoadValidationResultDir(self):
loaded_result = model_eval_lib.load_validation_result(os.path.dirname(path))
self.assertTrue(loaded_result.validation_ok)

# PR 189: Remove the `expectedFailure` mark if the test passes
@unittest.expectedFailure
def testLoadValidationResultEmptyFile(self):
path = os.path.join(
absltest.get_default_test_tmpdir(), constants.VALIDATIONS_KEY
Expand Down
12 changes: 12 additions & 0 deletions tensorflow_model_analysis/extractors/inference_base_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
from tensorflow_serving.apis import logging_pb2
from tensorflow_serving.apis import prediction_log_pb2

import unittest


class TfxBslPredictionsExtractorTest(testutil.TensorflowModelAnalysisTest):

Expand Down Expand Up @@ -70,6 +72,8 @@ def _create_tfxio_and_feature_extractor(
)
return tfx_io, feature_extractor

# PR 189: Remove the `skip` mark if the test passes
@unittest.skip("This test contains errors")
def testIsValidConfigForBulkInferencePass(self):
saved_model_proto = text_format.Parse(
"""
Expand Down Expand Up @@ -129,6 +133,8 @@ def testIsValidConfigForBulkInferencePass(self):
)
)

# PR 189: Remove the `skip` mark if the test passes
@unittest.skip("This test contains errors")
def testIsValidConfigForBulkInferencePassDefaultSignatureLookUp(self):
saved_model_proto = text_format.Parse(
"""
Expand Down Expand Up @@ -184,6 +190,8 @@ def testIsValidConfigForBulkInferencePassDefaultSignatureLookUp(self):
)
)

# PR 189: Remove the `skip` mark if the test passes
@unittest.skip("This test contains errors")
def testIsValidConfigForBulkInferenceFailNoSignatureFound(self):
saved_model_proto = text_format.Parse(
"""
Expand Down Expand Up @@ -239,6 +247,8 @@ def testIsValidConfigForBulkInferenceFailNoSignatureFound(self):
)
)

# PR 189: Remove the `expectedFailure` mark if the test passes
@unittest.expectedFailure
def testIsValidConfigForBulkInferenceFailKerasModel(self):
saved_model_proto = text_format.Parse(
"""
Expand Down Expand Up @@ -296,6 +306,8 @@ def testIsValidConfigForBulkInferenceFailKerasModel(self):
)
)

# PR 189: Remove the `expectedFailure` mark if the test passes
@unittest.expectedFailure
def testIsValidConfigForBulkInferenceFailWrongInputType(self):
saved_model_proto = text_format.Parse(
"""
Expand Down
3 changes: 3 additions & 0 deletions tensorflow_model_analysis/metrics/metric_specs_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"""Tests for metric specs."""

import json
import unittest

import tensorflow as tf
from tensorflow_model_analysis.metrics import calibration
Expand All @@ -37,6 +38,8 @@ def _maybe_add_fn_name(kv, name):

class MetricSpecsTest(tf.test.TestCase):

# PR 189: Remove the `expectedFailure` mark if the test passes
@unittest.expectedFailure
def testSpecsFromMetrics(self):
metrics_specs = metric_specs.specs_from_metrics(
{
Expand Down
2 changes: 2 additions & 0 deletions tensorflow_model_analysis/utils/model_util_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,8 @@ def testGetDefaultModelSignatureFromSavedModelProtoWithServingDefault(self):
model_util.get_default_signature_name_from_saved_model_proto(
saved_model_proto))

# PR 189: Remove the `expectedFailure` mark if the test passes
@unittest.expectedFailure
def testGetDefaultModelSignatureFromModelPath(self):
saved_model_proto = text_format.Parse(
"""
Expand Down
Loading