Fix/javadoc script #555
Merged
Fix/javadoc script #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
karllessard
commented
Aug 30, 2024
karllessard
commented
- disable broken Linux Arm64 build
Craigacp
reviewed
Aug 30, 2024
tools/build_java_api_docs.py
Outdated
| output_dir=pathlib.Path(FLAGS.output_dir), | ||
| site_path=pathlib.Path(FLAGS.site_path)) | ||
| site_path=pathlib.Path(FLAGS.site_path), | ||
| script_path=pathlib.Path(REPO_ROOT/'tools/run-javadoc-for-tf.sh'), # FIXME use default one?? |
There was a problem hiding this comment.
This file isn't in the PR.
Craigacp
reviewed
Aug 30, 2024
tools/build_java_api_docs.py
Outdated
| else: | ||
| local_repo = Repo(local_repo_path) | ||
| local_repo.remotes['origin'].fetch() | ||
| local_repo.git.checkout('v1.0.0') |
There was a problem hiding this comment.
Maybe this should be defined up top as TF_NDARRAY_VERSION so it's easier to see?
|
I added the copy of the javadoc script I had, for local testing |
Craigacp
approved these changes
Aug 31, 2024
karllessard
added a commit
that referenced
this pull request
Sep 24, 2024
karllessard
added a commit
that referenced
this pull request
Sep 24, 2024
* Graph is changed to public in Session.java (#535) * Merge doc changes from r1.0 * Fix unknown shapes in signature proto * Update NdArray dependency * Fix spotless check * Fix broadcastMask/Update Accept partially unknown shaped mask * linux-arm64: add build artifact item for linux-arm64 platform TensorFlow v2.16.1 wheel artifacts and the jar build support are added * linux-arm64 fixes to package the right dependencies into tensorflow native jar * Fix javadoc Co-authored-by: Adam Pocock <[email protected]> * Add instructions for new module names (#554) * CI: add CI support for linux-arm64 platform (#548) * Fix/javadoc script (#555) * Update macos x86 runner * Don’t deploy missing linux-arm64 build * Cleanup missing Linux-arm64 dependencies * Use org large runners for Linux arm64 * Using setup-java for linux-arm64 * Switch to zulu * Add back Linux arm64 artifacts (#556) * Upgrade to TF2.16.2 (#557) * Link to libomp full name (#558) * Releasing 1.0.0 RC2 --------- Co-authored-by: manojava98 <[email protected]> Co-authored-by: Sunita Nadampalli <[email protected]> Co-authored-by: Adam Pocock <[email protected]> Co-authored-by: snadampal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.