Skip to content

Conversation

@yongtang
Copy link
Member

This is the initial commit of gcs modular file system plugin authored
by @vnvo2409. This is the first step with code moved here.

Several things that needs to be done in follow up PRs:

  1. The thread-related functions was using TensorFlow APIs. However, they are not exposed in TF 2.4 so we may need to convert them here first.
  2. The testing has not been touched yet. It will be covered in follow up PRs.

This PR is a first step, as the content is pretty big so split into steps.

Signed-off-by: Yong Tang [email protected]

This is the initial commit of gcs modular file system plugin authored
by vnvo2409. This is the first step with code moved here.

Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
@yongtang yongtang force-pushed the gcs-plugin branch 2 times, most recently from a77a965 to db1565e Compare November 19, 2020 02:53
Signed-off-by: Yong Tang <[email protected]>
@yongtang yongtang force-pushed the gcs-plugin branch 2 times, most recently from e107179 to 73622f9 Compare November 19, 2020 04:14
@vnghia
Copy link
Contributor

vnghia commented Nov 19, 2020

LGTM. Thank you !

@kvignesh1420
Copy link
Member

@yongtang thank you for migrating the plugins. Also, credit to @vnvo2409 for writing the plugins.

@yongtang yongtang merged commit 5e73f46 into tensorflow:master Nov 19, 2020
@yongtang yongtang deleted the gcs-plugin branch November 19, 2020 16:26
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
…ow#1203)

* Initial commit of gcs modular file system plugin (vnvo2409)

This is the initial commit of gcs modular file system plugin authored
by vnvo2409. This is the first step with code moved here.

Signed-off-by: Yong Tang <[email protected]>

* Namespace changes to avoid collision & conflict

Signed-off-by: Yong Tang <[email protected]>

* Add wrapper to GCSFileSystem so that it will only lazy-loaded.

Signed-off-by: Yong Tang <[email protected]>

* Disable scheme check

Signed-off-by: Yong Tang <[email protected]>

* Migrate GetTempFileName

Signed-off-by: Yong Tang <[email protected]>

* Add placeholder APIs

Signed-off-by: Yong Tang <[email protected]>

* Disable for now.

Signed-off-by: Yong Tang <[email protected]>

* Empty commit to trigger GitHub Actions

Signed-off-by: Yong Tang <[email protected]>

* Rename the guards for header inclusion based on review feedback.

Signed-off-by: Yong Tang <[email protected]>
@vnghia vnghia mentioned this pull request Mar 6, 2021
zheolong pushed a commit to zheolong/io-1 that referenced this pull request Jul 24, 2025
…ow#1203)

* Initial commit of gcs modular file system plugin (vnvo2409)

This is the initial commit of gcs modular file system plugin authored
by vnvo2409. This is the first step with code moved here.

Signed-off-by: Yong Tang <[email protected]>

* Namespace changes to avoid collision & conflict

Signed-off-by: Yong Tang <[email protected]>

* Add wrapper to GCSFileSystem so that it will only lazy-loaded.

Signed-off-by: Yong Tang <[email protected]>

* Disable scheme check

Signed-off-by: Yong Tang <[email protected]>

* Migrate GetTempFileName

Signed-off-by: Yong Tang <[email protected]>

* Add placeholder APIs

Signed-off-by: Yong Tang <[email protected]>

* Disable for now.

Signed-off-by: Yong Tang <[email protected]>

* Empty commit to trigger GitHub Actions

Signed-off-by: Yong Tang <[email protected]>

* Rename the guards for header inclusion based on review feedback.

Signed-off-by: Yong Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants