Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build workflow via docker #259

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Sep 23, 2024

Adds build workflow via docker based on the instructions specified here: https://github.com/tensorflow/data-validation#build-with-docker

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@peytondmurray
Copy link

peytondmurray commented Sep 25, 2024

I think we also need to add the part of the workflow that automatically uploads to PyPI for releases, like this https://github.com/tensorflow/tfx/pull/6892/files.

One other thing - can you add a workflow_dispatch trigger? It's sometimes useful for debugging or manually releasing.

Copy link

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need a pip install twine before running twine check.

@peytondmurray peytondmurray self-requested a review September 29, 2024 23:20
Copy link

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peytondmurray peytondmurray merged commit bca0f85 into tensorflow:master Oct 1, 2024
5 checks passed
@aktech aktech deleted the build-workflow branch October 1, 2024 08:57
@aktech aktech mentioned this pull request Oct 4, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants