fix: chown all the files for mamba under /opt/conda (#1961)

fix: chown all the files for mamba under /opt/conda Signed-off-by: Keming <[email protected]>
tensorchord · Jan 26, 2025 · 307fdbd · 307fdbd
1 parent 3b1d272
commit 307fdbd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -189,6 +189,7 @@ jobs:
     if: github.repository == 'tensorchord/envd' && startsWith(github.ref, 'refs/tags/v')
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         include:
           - build_func: build

diff --git a/envd/api/v1/__init__.py b/envd/api/v1/__init__.py
@@ -47,7 +47,7 @@ def shell(name: str = "bash"):
     """Interactive shell
 
     Args:
-        name (str): shell name (i.e. `zsh`, `bash`)
+        name (str): shell name (i.e. `zsh`, `bash`, `fish`)
     """
 
 

diff --git a/pkg/lang/ir/v1/conda.go b/pkg/lang/ir/v1/conda.go
@@ -163,7 +163,8 @@ func (g generalGraph) compileCondaEnvironment(root llb.State) (llb.State, error)
 func (g *generalGraph) installConda(root llb.State) llb.State {
 	if g.Dev {
 		// We only create envd user for dev env.
-		g.UserDirectories = append(g.UserDirectories, fmt.Sprintf("%s/envs/envd", condaRootPrefix))
+		// `micromamba` needs to modify the conda directory.
+		g.UserDirectories = append(g.UserDirectories, condaRootPrefix)
 	}
 	if g.CondaConfig.UseMicroMamba {
 		return g.installMicroMamba(root)
-Original file line number
+Diff line change
@@ Expand Up / @@ -47,7 +47,7 @@ def shell(name: str = "bash"): @@
         """Interactive shell
         Args:
-            name (str): shell name (i.e. `zsh`, `bash`)
+            name (str): shell name (i.e. `zsh`, `bash`, `fish`)
         """
@@ Expand Down @@