Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default settings are always written to the workspace settings.json #42

Closed
alexisbg opened this issue Oct 28, 2023 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@alexisbg
Copy link

Since Koverage 0.0.16, all its default settings are always written to the workspace settings.json:

{
  "koverage.coverageCommand": "",
  "koverage.autoRefresh": true,
  "koverage.autoRefreshDebounce": 3000,
  "koverage.coverageFileNames": [
    "lcov.info",
    "cov.xml",
    "clover.xml",
    "coverage.xml",
    "jacoco.xml"
  ],
  "koverage.coverageFilePaths": [
    "**"
  ],
  "koverage.lowCoverageThreshold": 50,
  "koverage.sufficientCoverageThreshold": 70,
}

If I try to remove them, they are written again. How to avoid this behavior?

@tenninebt
Copy link
Owner

Yes, I detected right after releasing, the fix is on the way, probably today or tomorrow. Sorry for the inconvenience.

@tenninebt
Copy link
Owner

tenninebt commented Oct 29, 2023

fixed by 9ba9f38
Release v0.0.19

@tenninebt
Copy link
Owner

@alexisbg Did you install the latest update? Do you confirm it is fixed?

@tenninebt tenninebt added the bug Something isn't working label Nov 2, 2023
@alexisbg
Copy link
Author

alexisbg commented Nov 5, 2023

@tenninebt Yes, Koverage has been updated to v0.0.19 on 2 projects and the issue seems to be fixed.
Merci !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants