Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to use absolute file paths #21

Closed
GitMensch opened this issue Nov 14, 2022 · 10 comments
Closed

unable to use absolute file paths #21

GitMensch opened this issue Nov 14, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@GitMensch
Copy link

Project is stored in "/home/project" (so that's the workspace folder), the build is done in "/tmp/project" (and therefore coverage files are to be found there.

The following setup does work with coverage-gutters, but doesn't with koverage

    "coverage-gutters.coverageBaseDir": "/tmp/project",
    "koverage.coverageFilePaths": [
        "/tmp/project"
    ],

koverage output says:

"message": "createFileSystemWatcher(Pattern = /home/project/**/{/tmp/project/**})",
"message": "Could not find a Coverage file!",

Is the configuration wrong or does Koverage really not support absolute names yet (I didn't get it working with ../ entries either)?

@tenninebt
Copy link
Owner

tenninebt commented Nov 22, 2022

Sorry, been very busy lately. Yes, I think the current design assumes that the coverage files are in the open workspace.
I'll have a look by the end of this week to see what's blocking and what can be done.
(Obviously, if you have a fix to suggest, please do, just open a pull-request and I'll review it.)

@GitMensch
Copy link
Author

Obviously, if you have a fix to suggest, please do, just open a pull-request and I'll review it

Thank you for the offer but this time I even had not looked at a solution.

I'll have a look by the end of this week to see what's blocking and what can be done.

That's nice.

@GitMensch
Copy link
Author

Any chance to inspect that, yet?

@tenninebt
Copy link
Owner

Hey, sorry, been extremely busy.

I'm working on it now, a fix should be here this week. I might build a version for you to test before release it, would you have some slack sometime this week to test?

@GitMensch
Copy link
Author

I should be able to test that shortly after a test .vsix is made availabe anywhere.

@tenninebt
Copy link
Owner

vscode-koverage-0.0.13-beta.vsix.zip
Give it a shot, and tell how things work out for you. (This version should be able to handle both absolute paths and glob)

@GitMensch
Copy link
Author

Test result: the path issues are all gone, there is only no calculation if the config is broken.
But the coverage is always shown as 100% without any details, even if the old working paths are used (installing the latest version I get 72% and the expected tree with the details).

@tenninebt
Copy link
Owner

tenninebt commented Dec 6, 2022

Test result: the path issues are all gone, there is only no calculation if the config is broken. But the coverage is always shown as 100% without any details, even if the old working paths are used (installing the latest version I get 72% and the expected tree with the details).

Can I have a screenshot and a bit more details on what you mean by "config is broken"? (Thanks for your help)
Then, even after you fix the config, there is still no calculation you mean (Like the plugin is in a bad state?)? (A recording of the screen or a more explicit use case will really help)
You can reach me on Discord as tenninebt#3384 if you have time to discuss further, better than github.

@GitMensch

This comment was marked as resolved.

@GitMensch
Copy link
Author

I can confirm that upcoming 0.13 fixes both this and #22

tenninebt added a commit that referenced this issue Dec 7, 2022
@tenninebt tenninebt added the enhancement New feature or request label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants