From CGO_ENABLED=0 from make install #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
force-pushed
the
bugfix/install-stdlib
branch
from
8cdfcde to
cb2772a
Compare
melekes
reviewed
Dec 8, 2017
Makefile
Outdated
| @@ -12,7 +12,7 @@ BUILD_FLAGS = -ldflags "-X github.com/tendermint/tendermint/version.GitCommit=`g | |||
| all: get_vendor_deps install test | |||
|
|
|||
| install: | |||
| CGO_ENABLED=0 go install $(BUILD_FLAGS) ./cmd/tendermint | |||
| go install $(BUILD_FLAGS) ./cmd/tendermint | |||
|
|
|||
| build: | |||
| CGO_ENABLED=0 go build $(BUILD_FLAGS) -o build/tendermint ./cmd/tendermint/ | |||
There was a problem hiding this comment.
maybe we should remove it from here too to be consistent?
There was a problem hiding this comment.
It doesn't have the same behavior on go build as per the comment. But sure, I can remove it. Will squish commits together
It was writing to stdlib packages net, x/crypto, etc. and failing when it didn't have write access to them (which it often shouldn't) Fixes issue #941 Explained in golang issue: golang/go#18981 (fixed in develop/1.10)
ethanfrey
force-pushed
the
bugfix/install-stdlib
branch
from
cb2772a to
9657d18
Compare
melekes
approved these changes
Dec 8, 2017
Codecov Report
@@ Coverage Diff @@
## develop #942 +/- ##
===========================================
+ Coverage 58.86% 59.08% +0.22%
===========================================
Files 100 100
Lines 9784 9784
===========================================
+ Hits 5759 5781 +22
+ Misses 3476 3460 -16
+ Partials 549 543 -6 |
Cashmaney
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Aug 2, 2023
…#942) Bumps [docker/login-action](https://github.com/docker/login-action) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2.1.0...v2.2.0) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was writing to stdlib packages net, x/crypto, etc. and failing when it didn't have write access to them (which it often shouldn't)
Fixes issue #941
Explained in golang issue: golang/go#18981 (fixed in develop/1.10)