-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: panic due to negative coin amount when remaining is negative #80
Merged
jaybxyz
merged 9 commits into
tendermint:main
from
jaybxyz:kogisin/78-fix-negative-amount
Feb 5, 2022
Merged
fix: panic due to negative coin amount when remaining is negative #80
jaybxyz
merged 9 commits into
tendermint:main
from
jaybxyz:kogisin/78-fix-negative-amount
Feb 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This codecov issue is strange
|
After doing some research, it seems like it is working and not working from time to time
References |
Resolved the above issue by change the coverage file extension to xml. |
jaybxyz
requested review from
dongsam,
hallazzang and
CoinedLiberty
as code owners
February 4, 2022 14:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #78 and #79
Tasks
IsLT()
before substituting remaining coin from receive coinBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes