This repository was archived by the owner on Dec 18, 2022. It is now read-only.
Cleanup Innosetup installer and CMake module#578
Merged
Conversation
emabrey
changed the title
Rename usage of outdated Innosetup functions Configure CMake to use the same build type for Innosetup target Use Tenacity logos Update readme information displayed post-install Update license information displayed pre-install Fix installer generation Cleanup innosetup configuration Signed-off-by: Emily Mabrey <emabrey@tenacityaudio.org>
emabrey
force-pushed
the
emabrey/innosetup-improvements
branch
from
51d26b3 to
d73e9eb
Compare
Contributor
|
I have no objections to this but I also am not very familiar with how this works and don't really know what to look for reviewing. As long as someone tests the GitHub Actions artifact for this PR on Windows and confirms it works, I'm okay with merging this. |
Member
Author
|
I tested it and it seems to work on Windows using both the 64 bit and 32 bit installer exes. |
Contributor
|
Thanks for taking care of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: (direct link to the issue)
Checklist
-sorSigned-off-by* (See: Contributing § DCO)* indicates required