Skip to content
This repository was archived by the owner on Dec 18, 2022. It is now read-only.

[CI] Use scoop instead of choco for installing tools on Windows#557

Merged
n0toose merged 2 commits intotenacityteam:masterfrom
AnotherFoxGuy:no-choco
Sep 1, 2021
Merged

[CI] Use scoop instead of choco for installing tools on Windows#557
n0toose merged 2 commits intotenacityteam:masterfrom
AnotherFoxGuy:no-choco

Conversation

@AnotherFoxGuy
Copy link
Contributor

Apparently chocolatey sometimes suffers from an issue where it is unable to connect to the choco servers
This PR fixes that by completely replacing choco with scoop

(see https://github.com/tenacityteam/tenacity/pull/545#discussion_r697915564)

Checklist
  • I have signed off my commits using -s or Signed-off-by* (See: Contributing § DCO)
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code*
  • I made sure the title of the PR reflects the core meaning of the issue you are solving*
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"*

* indicates required

@AnotherFoxGuy AnotherFoxGuy force-pushed the no-choco branch 2 times, most recently from 1ff460c to fd8f53a Compare August 29, 2021 12:24
Be-ing
Be-ing previously approved these changes Aug 29, 2021
@Be-ing Be-ing mentioned this pull request Aug 29, 2021
5 tasks
caughtquick
caughtquick previously approved these changes Aug 29, 2021
@emabrey
Copy link
Member

emabrey commented Aug 30, 2021

Please move the Windows install step back into the bash script or move all the components of the bash script into the github workflow (Mac and Linux).

@AnotherFoxGuy AnotherFoxGuy dismissed stale reviews from caughtquick and Be-ing via a367b1e August 31, 2021 16:08
@AnotherFoxGuy AnotherFoxGuy force-pushed the no-choco branch 2 times, most recently from a367b1e to 28dd831 Compare August 31, 2021 16:09
emabrey
emabrey previously approved these changes Aug 31, 2021
Be-ing
Be-ing previously approved these changes Aug 31, 2021
Signed-off-by: Edgar <Edgar@AnotherFoxGuy.com>
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
This change removes the script `script/ci/dependencies.sh` and moves it
to the GitHub Actions workflow instead.

Signed-off-by: Edgar <Edgar@AnotherFoxGuy.com>
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
@n0toose n0toose dismissed stale reviews from Be-ing and emabrey via 543bf3b September 1, 2021 20:44
@n0toose n0toose merged commit 543bf3b into tenacityteam:master Sep 1, 2021
@AnotherFoxGuy
Copy link
Contributor Author

Flatpak died because one of the servers was down
CodeQL died because it is still using the deps.sh script, I will fix that soon

@AnotherFoxGuy AnotherFoxGuy deleted the no-choco branch September 2, 2021 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants