[Build] Allow building without Conan#234
Conversation
|
Thanks for working on this but I am in doubt this is a good direction to continue. Audacity is planning more changes to their dependency management, so I think it may be difficult to maintain this in the future. Judging from what they have done so far and their continued snide remarks towards Linux users I have little confidence those changes will turn out very well. I think it will be easier to maintain to bypass the Conan mess entirely as #228 does. |
6c3c508 to
9497bc5
Compare
|
What is the status of this PR? #228 has made significant progress on the same front. If this is no longer actively developed, please close this PR. |
|
To be honest, it could be good if the |
9497bc5 to
7acabb0
Compare
It builds with wxWidgets V3.1.5, but I haven't tested if it runs on linux |
7acabb0 to
271ad6c
Compare
|
This may be very important for our first release. See: https://github.com/tenacityteam/tenacity/pull/300#issuecomment-884782522 |
271ad6c to
c4e9ddc
Compare
|
Could this be rebased into one commit |
c4e9ddc to
f8cfc67
Compare
f8cfc67 to
1f48f2c
Compare
|
FYI: 🎉 emojis look good on the GitHub front-end but weird on the Git CLI and other frontends. I'd suggest changing the |
|
Building this without Conan seems to work. |
1f48f2c to
0ed6c2e
Compare
0ed6c2e to
282c98d
Compare
n0toose
left a comment
There was a problem hiding this comment.
Seems good to me, I think building this with Conan using the correct parameter needs some further testing.
Be-ing
left a comment
There was a problem hiding this comment.
Please rename Findlibmp3lame.cmake to Findmp3lame.cmake for consistency with the CMake target name in vcpkg.
282c98d to
e44a887
Compare
Renaming lame will completely break the buildsystem, I will open a separate PR to fix it |
Signed-off-by: Edgar <Edgar@AnotherFoxGuy.com>
e44a887 to
4145f3c
Compare

fixes: #75
PR for building without having Conan installed
STATUS:
Builds and runs on Manjaro with
wxgtk3-dev 3.1.5-2(See: https://github.com/tenacityteam/tenacity/pull/234#issuecomment-884876066)Contributor stuff
✅ The code in this pull request is licensed under "GPLv2 or any later version"*
✅ I made sure the code compiles on my machine
✅ I made sure there are no unnecessary changes in the code*
✅ I made sure the title of the PR reflects the core meaning of the issue you are solving*
✅ I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"*