This repository was archived by the owner on Dec 18, 2022. It is now read-only.
CMake: fix search of LAME from system with module from Mixxx#226
Closed
Be-ing wants to merge 1 commit intotenacityteam:masterfrom
Closed
CMake: fix search of LAME from system with module from Mixxx#226Be-ing wants to merge 1 commit intotenacityteam:masterfrom
Be-ing wants to merge 1 commit intotenacityteam:masterfrom
Conversation
Contributor
Author
|
Audacity can't copy this fix because it is licensed GPL v2 or later 😁 |
Mixxx is licensed GPLv2 or later. This CMake module comes from: https://github.com/mixxxdj/mixxx/blob/main/cmake/modules/Findmp3lame.cmake Thanks to @Holzhaus for writing the CMake module. Signed-off-by: Be <be@mixxx.org>
fossdd
suggested changes
Jul 12, 2021
Member
fossdd
left a comment
There was a problem hiding this comment.
Can you add lame to the .builds/archlinux.yml file, to fix the builds.sr.ht CI?
There's an almost-comprehensive list of the packages for building without conan somewhere here, in a failed Archlinux build. |
Contributor
Author
|
Closing in favor of #228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixxx is licensed GPLv2 or later. This CMake module comes from:
https://github.com/mixxxdj/mixxx/blob/main/cmake/modules/Findmp3lame.cmake
Thanks to @Holzhaus for writing the CMake module.
Signed-off-by: Be be@mixxx.org
Resolves: #225
I am not certain if this fully works yet because there are still other build problems using system libraries.
-sorSigned-off-by* (See: Contributing § DCO)* indicates required