Skip to content
This repository was archived by the owner on Dec 18, 2022. It is now read-only.

CMake: fix search of LAME from system with module from Mixxx#226

Closed
Be-ing wants to merge 1 commit intotenacityteam:masterfrom
Be-ing:build_lame
Closed

CMake: fix search of LAME from system with module from Mixxx#226
Be-ing wants to merge 1 commit intotenacityteam:masterfrom
Be-ing:build_lame

Conversation

@Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 11, 2021

Mixxx is licensed GPLv2 or later. This CMake module comes from:
https://github.com/mixxxdj/mixxx/blob/main/cmake/modules/Findmp3lame.cmake
Thanks to @Holzhaus for writing the CMake module.

Signed-off-by: Be be@mixxx.org

Resolves: #225

I am not certain if this fully works yet because there are still other build problems using system libraries.

  • I have signed off my commits using -s or Signed-off-by* (See: Contributing § DCO)
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code*
  • I made sure the title of the PR reflects the core meaning of the issue you are solving*
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"*

* indicates required

@Be-ing Be-ing marked this pull request as draft July 11, 2021 23:40
@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 11, 2021

Audacity can't copy this fix because it is licensed GPL v2 or later 😁

Mixxx is licensed GPLv2 or later. This CMake module comes from:
https://github.com/mixxxdj/mixxx/blob/main/cmake/modules/Findmp3lame.cmake
Thanks to @Holzhaus for writing the CMake module.

Signed-off-by: Be <be@mixxx.org>
Copy link
Member

@fossdd fossdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add lame to the .builds/archlinux.yml file, to fix the builds.sr.ht CI?

@nbsp
Copy link

nbsp commented Jul 12, 2021

Can you add lame to the .builds/archlinux.yml file, to fix the builds.sr.ht CI?

There's an almost-comprehensive list of the packages for building without conan somewhere here, in a failed Archlinux build.

@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 13, 2021

Closing in favor of #228

@Be-ing Be-ing closed this Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake searches for LAME pkgconfig file that does not exist

3 participants