-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 623 add wa sv2 for export/reports download #623
base: master
Are you sure you want to change the base?
Feature/issue 623 add wa sv2 for export/reports download #623
Conversation
Export scan results Download exported scan
My apologies, I clicked the button too soon to start a pull request, I have done my own unit testing but haven't figured out regression tests for this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @fullofentropy, Thanks for the PR. I've added a few comments. In addition, please add tests confirming the behaviour.
Hi! If this PR fixes #622, please ensure it's properly written in the PR description (without space between "#" and 622). Thanks! |
corrected spelling and punctuation
…e consistantly. They stick at 202 response rather than provide 200 when ready.
@aseemsavio, I will add some pytests to confirm the behavior, question below as well.
|
still need dummy test data corrected discription
this needs to be updated by adding a WAS test data to request a report with
So in the current feature branch, I have added 3 pytest unit tests that currently fail because I do not know of a WAS scan_id or history_id I can use for testing. Could someone assist me with this? I also installed the html report (in the zip) generator for the pytest execution on this branch. The regression test was ran and passed using the fork, it is my added (and incomplete) tests that are failing. Note: This is the first time I am using pytest, so I spent some time learning it and some of the extended features this project uses. |
FYI: I did test the implementation using my own tenable credentials and WAS based scans. |
Hi @fullofentropy. I'll try and explain as best I can. You must have seen your test function accepting As you may be familiar, pytest records the HTTP request and response in the cassette (yaml) files, so that it can use the recorded response during the subsequent test runs instead of actually making HTTP calls every time. To achieve this, you need to put valid credentials in the You must make sure to remove your credential from the Hope this helps. Let me know if you need any more information. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #623
Type of change
Added
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration: Kali Linux VM with cloud.tenable.com APIs
Checklist: