fix: tweak features and add cargo hack check#523
Merged
Conversation
0xKitsune
approved these changes
Oct 22, 2025
Contributor
|
@klkvr just bumping this. Since linting is taking > 30 minutes with this change, wydt about running this nightly rather than on every PR? |
Contributor
|
This change is very welcome, but powerset is indeed heavy. Maybe an alternative is to run it on merge to main? Because I was bitten by this before, |
Member
Author
|
updated to run only on new commits to main |
SuperFluffy
requested changes
Oct 28, 2025
| reth-ethereum = { git = "https://github.com/paradigmxyz/reth", rev = "f6a583f" } | ||
| reth-ethereum-cli = { git = "https://github.com/paradigmxyz/reth", rev = "f6a583f" } | ||
| reth-e2e-test-utils = { git = "https://github.com/paradigmxyz/reth", rev = "f6a583f" } | ||
| reth = { git = "https://github.com/paradigmxyz/reth", rev = "020eb6a" } |
Contributor
There was a problem hiding this comment.
I don't think this should be in this PR.
Merged
klkvr
added a commit
that referenced
this pull request
Oct 28, 2025
applies reth bump from #523 cc @SuperFluffy
SuperFluffy
approved these changes
Oct 28, 2025
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
applies reth bump from tempoxyz#523 cc @SuperFluffy
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
depends on paradigmxyz/reth#19212 closes tempoxyz#404 adds `cargo hack check --feature-powerset` run, fixes failures that appeared --------- Co-authored-by: Federico Gimenez <federico.gimenez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on paradigmxyz/reth#19212
closes #404
adds
cargo hack check --feature-powersetrun, fixes failures that appeared