Move Core-specific test utilities out of the Common crate - #1237
Merged
Merged
Conversation
mjameswh
marked this pull request as ready for review
April 27, 2026 16:16
mjameswh
force-pushed
the
move-core-test-utils-out-of-common
branch
from
April 27, 2026 17:21
bbc775c to
004d6b2
Compare
chris-olszewski
approved these changes
Apr 28, 2026
Comment on lines
+2394
to
+2395
| CoreInternalFlags::IdAndTypeDeterminismChecks as u32, | ||
| CoreInternalFlags::UpsertSearchAttributeOnPatch as u32, |
mjameswh
force-pushed
the
move-core-test-utils-out-of-common
branch
from
April 28, 2026 19:15
004d6b2 to
415d0d2
Compare
mjameswh
commented
Apr 28, 2026
| envconfig = ["dep:toml", "dep:dirs"] | ||
| serde_serialize = [] | ||
| test-utilities = ["history_builders"] | ||
| core-telemetry-bridge = ["dep:ringbuf", "dep:futures-channel"] |
Contributor
Author
There was a problem hiding this comment.
@chris-olszewski Note the casing inconsistency in serde_serialize vs other features.
mjameswh
commented
Apr 28, 2026
| # Exposes mocks and helpers used by sdk-core's own integration tests, benches, | ||
| # and the `histfetch` binary. Not part of the public API surface; downstream | ||
| # crates should not enable this feature. | ||
| test-utilities = ["dep:assert_matches", "dep:bimap"] |
Contributor
Author
There was a problem hiding this comment.
Is there a Rust convention for features that are not meant to be used publicly?
Member
There was a problem hiding this comment.
Not that I know of. We could prefix with __ to make the name convey internal usage, but I don't think that is a widely used pattern.
mjameswh
force-pushed
the
move-core-test-utils-out-of-common
branch
from
April 28, 2026 19:28
415d0d2 to
dfb0137
Compare
chris-olszewski
approved these changes
Apr 28, 2026
chris-olszewski
left a comment
chris-olszewski
left a comment
Member
There was a problem hiding this comment.
Looks like some casts need to be removed, but LGTM
This was referenced May 1, 2026
Closed
This was referenced May 15, 2026
Closed
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
HistoryBuilder,HistoryInfo,test_utils.rsand canned histories out of thecommoncreate to thesdk-corecrate.history_buildersandtest-utilitiesfeatures on thecommoncrate.Why
sdk-corecrate's internal tests. They are not meant for public usage.sdk-corecrate makes it possible forHistoryBuilderand canned histories to have access to theInternalFlagsenum.