Skip to content

rust-toolchain.toml and MSRV checks in CI - #1175

Merged
eamsden merged 5 commits into
masterfrom
eamsden/rust-toolchain-ci
Mar 24, 2026
Merged

eamsden merged 5 commits into
masterfrom
eamsden/rust-toolchain-ci

Conversation

@eamsden

@eamsden eamsden commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

What was changed

Add MSRV on temporalio-core-sdk crate, and add CI step to use cargo msrv to check it.

Why?

We want to have a rust-toolchain set to keep us up to date with the latest tooling, but also make sure that our published MSRV (a) exists and (b) is accurate.

Checklist

  • Verify CI working
  • remove feature branch from workflow push field after testing.
  • Check that installing cargo-msrv and building with an old toolchain version (via cargo msrv verify) don't break the Rust caching in CI. (made sure it doesn't by using a separate rust-cache key)
  1. Closes

  2. How was this tested:

  • Repeated pushes to github running CI
  • cargo check locally.
  1. Any docs updates needed?
    No

@CLAassistant

CLAassistant commented Mar 23, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@eamsden eamsden changed the title Eamsden/rust toolchain ci rust-toolchain.toml and MSRV checks in CI Mar 23, 2026
@semgrep-managed-scans

Copy link
Copy Markdown

Semgrep found 1 missing-explicit-permissions finding:

No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).

@eamsden
eamsden marked this pull request as ready for review March 23, 2026 23:44
@eamsden
eamsden requested a review from a team as a code owner March 23, 2026 23:44

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

Tip: disable this comment in your organization's Code Review settings.

@Sushisource Sushisource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@eamsden
eamsden merged commit 31798a4 into master Mar 24, 2026
62 of 68 checks passed
@eamsden
eamsden deleted the eamsden/rust-toolchain-ci branch March 24, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants