rust-toolchain.toml and MSRV checks in CI - #1175
Merged
Merged
Conversation
|
Semgrep found 1 No explicit |
eamsden
marked this pull request as ready for review
March 23, 2026 23:44
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review.
Tip: disable this comment in your organization's Code Review settings.
This was referenced Apr 3, 2026
Closed
This was referenced May 1, 2026
Closed
This was referenced May 15, 2026
Closed
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add MSRV on
temporalio-core-sdkcrate, and add CI step to usecargo msrvto check it.Why?
We want to have a rust-toolchain set to keep us up to date with the latest tooling, but also make sure that our published MSRV (a) exists and (b) is accurate.
Checklist
pushfield after testing.cargo-msrvand building with an old toolchain version (viacargo msrv verify) don't break the Rust caching in CI. (made sure it doesn't by using a separate rust-cache key)Closes
How was this tested:
cargo checklocally.No