Update Cloud Protos - #1171
Closed
mksample wants to merge 5 commits into
Closed
Update Cloud Protos#1171mksample wants to merge 5 commits into
mksample wants to merge 5 commits into
Conversation
|
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| (set_service_account_namespace_access, cloudreq::SetServiceAccountNamespaceAccessRequest, cloudreq::SetServiceAccountNamespaceAccessResponse); | ||
| (validate_account_audit_log_sink, cloudreq::ValidateAccountAuditLogSinkRequest, cloudreq::ValidateAccountAuditLogSinkResponse); | ||
| (create_billing_report, cloudreq::CreateBillingReportRequest, cloudreq:CreateBillingReportResponse); | ||
| (get_billing_report, cloudreq::GetBillingReportRequest, cloudreq:GetBillingReportResponse); |
There was a problem hiding this comment.
Missing proxier entries for new Cloud Service RPCs
High Severity
The diff adds 10 new RPCs to service.proto but only create_billing_report and get_billing_report are added to the proxier! macro for CloudService. The 8 missing RPCs (GetCurrentIdentity, GetAuditLogs, CreateAccountAuditLogSink, GetAccountAuditLogSink, GetAccountAuditLogSinks, UpdateAccountAuditLogSink, DeleteAccountAuditLogSink, GetNamespaceCapacityInfo) will cause the verify_all_cloud_service_methods_implemented test to panic, since it checks that every rpc in the proto is present in ALL_IMPLEMENTED_CLOUD_SERVICE_RPCS.
Additional Locations (1)
Member
|
This looks like a dupe of #1172? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Updates cloud protos to include new endpoints CreateBillingReport and GetBillingReport
Why?
Checklist
Closes
How was this tested:
Note
Medium Risk
Updates the public Cloud API surface (new RPCs/messages and some HTTP path changes), which may impact generated clients and downstream integrations if they depend on prior proto/REST definitions.
Overview
Updates the vendored Temporal Cloud proto bundle to
v0.12.0, including new proto modules and OpenAPI generation tweaks.Adds new CloudService capabilities for billing reports (
CreateBillingReport,GetBillingReport) plus additional Cloud API expansions (audit log retrieval/sink CRUD, namespace capacity info, and current-identity), and wires the new billing RPCs into the RustCloudServicegRPC proxy.Regenerates/adjusts API artifacts and build tooling: OpenAPI plugin bumped and configured (
disable_service_tags), CI workflow permissions/token wiring updated,bufdeps refreshed, and a couple of REST paths renamed (e.g., export-sink and audit-log-sink validation endpoints).Written by Cursor Bugbot for commit db41c40. This will update automatically on new commits. Configure here.