Skip to content

chore(ci): avoid caching rust on PR - #1159

Merged
chris-olszewski merged 1 commit into
masterfrom
olszewski/rust_cache_fix
Mar 16, 2026
Merged

chris-olszewski merged 1 commit into
masterfrom
olszewski/rust_cache_fix

Conversation

@chris-olszewski

Copy link
Copy Markdown
Member

What was changed

Two things:

  • Skip rust cache save in PRs
  • Add an extra 5 minutes to main job to make sure we populate the cache

Why?

The cache artifacts created on branches other than main don't get reused by other branches. Not sure saving these artifacts has much usage compared to just making sure the main cache is present.

For whatever reason creating the cache artifact takes ~1min on macos-intel runners which leads to the job just timing out consistently and the cache never getting populated. Bump up the timeout on main to avoid this.

Checklist

  1. Closes N/A

  2. How was this tested:

CI

  1. Any docs updates needed?

N/A

@chris-olszewski
chris-olszewski marked this pull request as ready for review March 16, 2026 23:19
@chris-olszewski
chris-olszewski requested a review from a team as a code owner March 16, 2026 23:19

@Sushisource Sushisource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@chris-olszewski
chris-olszewski merged commit 7a6a53f into master Mar 16, 2026
18 of 19 checks passed
@chris-olszewski
chris-olszewski deleted the olszewski/rust_cache_fix branch March 16, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants