Fix recording workflow termination metrics before receiving server response - #1112
Merged
Merged
Conversation
Sushisource
force-pushed
the
fix-workflow-termination-metric
branch
from
February 13, 2026 00:39
8f79eea to
5492af5
Compare
cretz
approved these changes
Feb 13, 2026
This was referenced Feb 19, 2026
Bump Temporalio.Extensions.DiagnosticSource from 1.9.0 to 1.11.1
InfinityFlowApp/aspire-temporal#281
Closed
Closed
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Title
Why?
Bugfix
Checklist
Closes [Feature Request] Workflow completion metrics should not be updated if recording task response fails #1084 and workflow_completed and workflow_continue_as_new counters should be logged after a successful reporting to the server features#222
How was this tested:
Added test / existing tests
Any docs updates needed?