Skip to content

Fix TemporalPatchVersion search attribute type to use KeywordList format - #1106

Merged
cretz merged 2 commits into
temporalio:masterfrom
cretz:fix-patch-version-search-attribute-type
Feb 3, 2026
Merged

cretz merged 2 commits into
temporalio:masterfrom
cretz:fix-patch-version-search-attribute-type

Conversation

@cretz

@cretz cretz commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

What was changed

#1032 used the wrong string for SA type for keyword list, causing some issues in parsing in some SDKs

Checklist

  1. Closes [Bug] Improper "type" used for TemporalPatchVersion search attribute #1105

@cretz
cretz requested a review from a team as a code owner February 2, 2026 20:09
.as_str_name()
.as_bytes()
.to_vec(),
"KeywordList".as_bytes().to_vec(),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a small comment with some of the description of #1105 would be helpful to prevent any accidental changes down the road.

@chris-olszewski

Copy link
Copy Markdown
Member

(Failures are from https://www.githubstatus.com/incidents/xwn6hjps36ty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Improper "type" used for TemporalPatchVersion search attribute

2 participants