Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ syntax = "proto3";
package coresdk.nexus;
option ruby_package = "Temporalio::Internal::Bridge::Api::Nexus";

import "google/protobuf/timestamp.proto";
import "temporal/api/common/v1/message.proto";
import "temporal/api/failure/v1/message.proto";
import "temporal/api/nexus/v1/message.proto";
Expand Down Expand Up @@ -54,6 +55,10 @@ message NexusTask {
// user's operation handler to continue doing work.
CancelNexusTask cancel_task = 2;
}
// The deadline for this request, parsed from the "Request-Timeout" header.
// Only set when variant is `task` and the header was present with a valid value.
// Represented as an absolute timestamp.
google.protobuf.Timestamp request_deadline = 3;
}

message CancelNexusTask {
Expand Down
158 changes: 157 additions & 1 deletion crates/sdk-core/src/core_tests/workers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -393,10 +393,16 @@ fn create_test_activity_task() -> PollActivityTaskQueueResponse {
}

fn create_test_nexus_task() -> PollNexusTaskQueueResponse {
create_test_nexus_task_with_headers(Default::default())
}

fn create_test_nexus_task_with_headers(
header: std::collections::HashMap<String, String>,
) -> PollNexusTaskQueueResponse {
PollNexusTaskQueueResponse {
task_token: b"nex-task".to_vec(),
request: Some(NexusRequest {
header: Default::default(),
header,
scheduled_time: None,
variant: Some(temporalio_common::protos::temporal::api::nexus::v1::request::Variant::StartOperation(
StartOperationRequest {
Expand Down Expand Up @@ -586,3 +592,153 @@ async fn test_task_type_combinations_unified(
worker.shutdown().await;
worker.finalize_shutdown().await;
}

#[tokio::test]
async fn nexus_request_deadline_missing_header() {
let mut client = mock_worker_client();
client
.expect_complete_nexus_task()
.returning(|_, _| Ok(RespondNexusTaskCompletedResponse::default()));
let nexus_task = create_test_nexus_task(); // No headers
let mut mocks = MocksHolder::from_client_with_custom(
client,
None::<stream::Empty<_>>,
None::<Vec<QueueResponse<PollActivityTaskQueueResponse>>>,
Some(vec![QueueResponse::from(nexus_task)]),
);
mocks.worker_cfg(|w| {
w.task_queue = "test-queue".to_string();
w.task_types = WorkerTaskTypes {
enable_workflows: false,
enable_local_activities: false,
enable_remote_activities: false,
enable_nexus: true,
};
w.skip_client_worker_set_check = true;
});
let worker = mock_worker(mocks);

let nexus_task = worker.poll_nexus_task().await.unwrap();
assert!(
nexus_task.request_deadline.is_none(),
"request_deadline should be None when header is missing"
);

worker
.complete_nexus_task(create_test_nexus_completion(nexus_task.task_token()))
.await
.unwrap();
worker.initiate_shutdown();
assert_matches!(
worker.poll_nexus_task().await.unwrap_err(),
PollError::ShutDown
);
worker.shutdown().await;
worker.finalize_shutdown().await;
}

#[tokio::test]
async fn nexus_request_deadline_valid_header() {
let mut client = mock_worker_client();
client
.expect_complete_nexus_task()
.returning(|_, _| Ok(RespondNexusTaskCompletedResponse::default()));
let mut headers = std::collections::HashMap::new();
headers.insert("request-timeout".to_string(), "30s".to_string());
let nexus_task = create_test_nexus_task_with_headers(headers);
let mut mocks = MocksHolder::from_client_with_custom(
client,
None::<stream::Empty<_>>,
None::<Vec<QueueResponse<PollActivityTaskQueueResponse>>>,
Some(vec![QueueResponse::from(nexus_task)]),
);
mocks.worker_cfg(|w| {
w.task_queue = "test-queue".to_string();
w.task_types = WorkerTaskTypes {
enable_workflows: false,
enable_local_activities: false,
enable_remote_activities: false,
enable_nexus: true,
};
w.skip_client_worker_set_check = true;
});
let worker = mock_worker(mocks);

let before = std::time::SystemTime::now();
let nexus_task = worker.poll_nexus_task().await.unwrap();
let after = std::time::SystemTime::now();

assert!(
nexus_task.request_deadline.is_some(),
"request_deadline should be Some when valid header is present"
);
let deadline: std::time::SystemTime = nexus_task.request_deadline.unwrap().try_into().unwrap();
// Deadline should be approximately 30s from now
let expected_min = before + Duration::from_secs(30);
let expected_max = after + Duration::from_secs(30);
assert!(
deadline >= expected_min && deadline <= expected_max,
"deadline {:?} should be between {:?} and {:?}",
deadline,
expected_min,
expected_max
);

worker
.complete_nexus_task(create_test_nexus_completion(nexus_task.task_token()))
.await
.unwrap();
worker.initiate_shutdown();
assert_matches!(
worker.poll_nexus_task().await.unwrap_err(),
PollError::ShutDown
);
worker.shutdown().await;
worker.finalize_shutdown().await;
}

#[tokio::test]
async fn nexus_request_deadline_invalid_header() {
let mut client = mock_worker_client();
client
.expect_complete_nexus_task()
.returning(|_, _| Ok(RespondNexusTaskCompletedResponse::default()));
let mut headers = std::collections::HashMap::new();
headers.insert("request-timeout".to_string(), "invalid".to_string());
let nexus_task = create_test_nexus_task_with_headers(headers);
let mut mocks = MocksHolder::from_client_with_custom(
client,
None::<stream::Empty<_>>,
None::<Vec<QueueResponse<PollActivityTaskQueueResponse>>>,
Some(vec![QueueResponse::from(nexus_task)]),
);
mocks.worker_cfg(|w| {
w.task_queue = "test-queue".to_string();
w.task_types = WorkerTaskTypes {
enable_workflows: false,
enable_local_activities: false,
enable_remote_activities: false,
enable_nexus: true,
};
w.skip_client_worker_set_check = true;
});
let worker = mock_worker(mocks);

let nexus_task = worker.poll_nexus_task().await.unwrap();
assert!(
nexus_task.request_deadline.is_none(),
"request_deadline should be None when header is invalid"
);

worker
.complete_nexus_task(create_test_nexus_completion(nexus_task.task_token()))
.await
.unwrap();
worker.initiate_shutdown();
assert_matches!(
worker.poll_nexus_task().await.unwrap_err(),
PollError::ShutDown
);
worker.shutdown().await;
worker.finalize_shutdown().await;
}
5 changes: 5 additions & 0 deletions crates/sdk-core/src/worker/nexus.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ use futures_util::{
Stream, StreamExt, stream,
stream::{BoxStream, PollNext},
};
use prost_types::Timestamp;
use std::{
collections::HashMap,
sync::{
Expand Down Expand Up @@ -264,13 +265,15 @@ where

let tt = TaskToken(t.resp.task_token.clone());
let mut timeout_task = None;
let mut request_deadline: Option<Timestamp> = None;
if let Some(timeout_str) = t
.resp
.request
.as_ref()
.and_then(|r| r.header.get(REQUEST_TIMEOUT_HEADER))
{
if let Ok(timeout_dur) = parse_request_timeout(timeout_str) {
request_deadline = Some((SystemTime::now() + timeout_dur).into());
let tt_clone = tt.clone();
let cancels_tx = self.cancels_tx.clone();
timeout_task = Some(tokio::task::spawn(async move {
Expand Down Expand Up @@ -331,12 +334,14 @@ where
);
Some(Ok(NexusTask {
variant: Some(nexus_task::Variant::Task(t.resp)),
request_deadline,
}))
},
Err(e) => Some(Err(PollError::TonicError(e)))
},
TaskStreamInput::Cancel(c) => Some(Ok(NexusTask {
variant: Some(nexus_task::Variant::CancelTask(c)),
request_deadline: None,
})),
TaskStreamInput::SourceComplete => {
source_done.cancel();
Expand Down
Loading