Skip to content

Conversation

@cretz
Copy link
Member

@cretz cretz commented Jun 10, 2024

What was changed

  • Remove protoc-wheel-0 dev dependency and add protoc to CI and build instructions
  • Fix minor issues with isort and Pydantic

Checklist

  1. Closes [Bug] protoc-wheel-0 dev dependency causing issues when building on musl-based distros like Alpine #412

@cretz cretz force-pushed the remove-proto-wheel branch 2 times, most recently from 6ecadc0 to a622f0d Compare June 10, 2024 16:02
@cretz cretz changed the title Remove proto wheel Remove proto wheel and other minor fixes Jun 10, 2024
@cretz cretz force-pushed the remove-proto-wheel branch 6 times, most recently from 17eb4e0 to 1003d28 Compare June 10, 2024 17:20
@cretz cretz force-pushed the remove-proto-wheel branch from 1003d28 to c3b1876 Compare June 10, 2024 17:36
@cretz cretz marked this pull request as ready for review June 10, 2024 17:36
@cretz cretz requested a review from a team as a code owner June 10, 2024 17:36
@cretz cretz merged commit 927415a into temporalio:main Jun 10, 2024
@cretz cretz deleted the remove-proto-wheel branch June 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] protoc-wheel-0 dev dependency causing issues when building on musl-based distros like Alpine

2 participants