Adds proper failure decoding in workflow activation #1192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This fixes the PayloadVisitor to properly handle failures with causes.
Why?
There is an issue when the custom codec is used. When the activity raises an exception with details a failure is properly encoded using a custom codc and is stored. But in the worker during the workflow activation the following error happens and workflow cannot proceed and eventually time outs:
This happens because the
PayloadVisitoused in_WorkflowWorker._handle_activationdoes not visitcausefield.Checklist
Closes [Bug] Failures in activites are not decoded in workflow when custom codec is used #1191
How was this tested:
I don't think so.