Skip to content

Conversation

@wagenrace
Copy link
Contributor

What was changed

Add text to the license field so pypi.org, pip, and license_scanner know what license it is using

Why?

image

Checklist

  1. Closes

  2. How was this tested: did not test

  3. Any docs updates needed?
    Nope

@wagenrace wagenrace requested a review from a team as a code owner October 21, 2025 21:19
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tconley1428 tconley1428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VegetarianOrc can you see if this is additive to your change #1151

@wagenrace
Copy link
Contributor Author

In #1151 the license is added as a classifier
That method is being deprecated by PEP 639
https://peps.python.org/pep-0639/#deprecate-license-classifiers

@VegetarianOrc
Copy link
Contributor

Looking at the shields implementation, this will be used for the badge with the classifier being a fallback. I think we should follow the PEP 639 guidelines, though let's split the license field into two fields, license and license-files since the pyproject.toml specification says the object is a legacy option.

@tconley1428
Copy link
Contributor

Based on my reading, I think having the classifier could be a problem. From the PEP:

If the License-Expression field is present, build tools MAY raise an error if one or more license classifiers is included in a Classifier field

@wagenrace
Copy link
Contributor Author

Looking at the shields implementation, this will be used for the badge with the classifier being a fallback. I think we should follow the PEP 639 guidelines, though let's split the license field into two fields, license and license-files since the pyproject.toml specification says the object is a legacy option.

You are right, let me update it

@tconley1428
Copy link
Contributor

You'll also have to sign the CLA for us to be able to accept the PR.

@wagenrace
Copy link
Contributor Author

@tconley1428 weird it did not take it the first time. Should be fine now

@VegetarianOrc VegetarianOrc merged commit 7f794d0 into temporalio:main Oct 24, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants