-
Notifications
You must be signed in to change notification settings - Fork 142
Update license in pyproject.toml #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tconley1428
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VegetarianOrc can you see if this is additive to your change #1151
|
In #1151 the license is added as a classifier |
|
Looking at the shields implementation, this will be used for the badge with the classifier being a fallback. I think we should follow the PEP 639 guidelines, though let's split the |
|
Based on my reading, I think having the classifier could be a problem. From the PEP:
|
You are right, let me update it |
|
You'll also have to sign the CLA for us to be able to accept the PR. |
Co-authored-by: Alex Mazzeo <[email protected]>
|
@tconley1428 weird it did not take it the first time. Should be fine now |
What was changed
Add text to the license field so pypi.org, pip, and license_scanner know what license it is using
Why?
Checklist
Closes
How was this tested: did not test
Any docs updates needed?
Nope