chore: enable public API compat validation

.github/workflows/ci.yml

@@ -93,6 +93,12 @@ jobs:
         run: |
           dotnet test --logger "console;verbosity=detailed" --logger "trx;LogFilePrefix=test-results" --results-directory tests/Temporalio.Tests/TestResults --blame-crash -v n --blame-hang-timeout 10m
 
+      - name: Validate package API surface
+        # Package API validation runs only during the Pack target and is
+        # platform-independent so running on one OS is sufficient.
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        run: dotnet pack -c Debug --no-restore
+
       - name: Upload test results
         if: ${{ !cancelled() }}
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7

Directory.Build.props

@@ -37,6 +37,14 @@
       leave revision off.
     -->
     <AssemblyVersion>1.14.1</AssemblyVersion>
+
+    <!--
+      Validate the public API surface of every packable project against the
+      previously published version. Auto-skips for IsPackable=false projects.
+      Bump PackageValidationBaselineVersion when releasing.
+    -->
+    <EnablePackageValidation>true</EnablePackageValidation>
+    <PackageValidationBaselineVersion>1.14.1</PackageValidationBaselineVersion>
   </PropertyGroup>
 
   <ItemGroup>

src/Temporalio.Api.Generator/Temporal.Api.Generator.csproj

@@ -2,6 +2,7 @@
 
   <PropertyGroup>
     <ImplicitUsings>enable</ImplicitUsings>
+    <IsPackable>false</IsPackable>
     <OutputType>Exe</OutputType>
     <TargetFramework>net10.0</TargetFramework>
   </PropertyGroup>

src/Temporalio.Extensions.DiagnosticSource/Temporalio.Extensions.DiagnosticSource.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <Description>Temporal SDK .NET Diagnostic Source Extension</Description>
-    <EnablePackageValidation Condition="'$(TargetFramework)' == 'netcoreapp3.1'">true</EnablePackageValidation>
     <IncludeSymbols>true</IncludeSymbols>
     <LangVersion>9.0</LangVersion>
     <PackageReadmeFile>README.md</PackageReadmeFile>

src/Temporalio.Extensions.Hosting/Temporalio.Extensions.Hosting.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <Description>Temporal SDK .NET Hosting and Dependency Injection Extension</Description>
-    <EnablePackageValidation Condition="'$(TargetFramework)' == 'netcoreapp3.1'">true</EnablePackageValidation>
     <IncludeSymbols>true</IncludeSymbols>
     <LangVersion>9.0</LangVersion>
     <PackageReadmeFile>README.md</PackageReadmeFile>

src/Temporalio.Extensions.OpenTelemetry/Temporalio.Extensions.OpenTelemetry.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <Description>Temporal SDK .NET OpenTelemetry Extension</Description>
-    <EnablePackageValidation Condition="'$(TargetFramework)' == 'netcoreapp3.1'">true</EnablePackageValidation>
     <IncludeSymbols>true</IncludeSymbols>
     <LangVersion>9.0</LangVersion>
     <PackageReadmeFile>README.md</PackageReadmeFile>

src/Temporalio/CompatibilitySuppressions.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
+<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+  <Suppression>
+    <DiagnosticId>CP0006</DiagnosticId>
+    <Target>M:Temporalio.Client.ITemporalClient.ListActivitiesAsync(System.String,Temporalio.Client.ActivityListOptions)</Target>
+    <Left>lib/netstandard2.0/Temporalio.dll</Left>
+    <Right>lib/netcoreapp3.1/Temporalio.dll</Right>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0006</DiagnosticId>
+    <Target>M:Temporalio.Client.ITemporalClient.ListSchedulesAsync(Temporalio.Client.Schedules.ScheduleListOptions)</Target>
+    <Left>lib/netstandard2.0/Temporalio.dll</Left>
+    <Right>lib/netcoreapp3.1/Temporalio.dll</Right>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0006</DiagnosticId>
+    <Target>M:Temporalio.Client.ITemporalClient.ListWorkflowsAsync(System.String,Temporalio.Client.WorkflowListOptions)</Target>
+    <Left>lib/netstandard2.0/Temporalio.dll</Left>
+    <Right>lib/netcoreapp3.1/Temporalio.dll</Right>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0006</DiagnosticId>
+    <Target>M:Temporalio.Worker.ITemporalWorkerPlugin.ReplayWorkflowsAsync(Temporalio.Worker.WorkflowReplayer,System.Func{Temporalio.Worker.WorkflowReplayer,System.Collections.Generic.IAsyncEnumerable{Temporalio.Worker.WorkflowReplayResult}},System.Threading.CancellationToken)</Target>
+    <Left>lib/netstandard2.0/Temporalio.dll</Left>
+    <Right>lib/netcoreapp3.1/Temporalio.dll</Right>
+  </Suppression>
+</Suppressions>

src/Temporalio/Temporalio.csproj

@@ -3,7 +3,6 @@
   <PropertyGroup>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Description>Temporal SDK for .NET</Description>
-    <EnablePackageValidation Condition="'$(TargetFramework)' == 'netcoreapp3.1'">true</EnablePackageValidation>
     <IncludeSymbols>true</IncludeSymbols>
     <LangVersion>9.0</LangVersion>
     <PackageReadmeFile>README.md</PackageReadmeFile>

tests/Directory.Build.props

@@ -0,0 +1,7 @@
+<Project>
+  <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
+
+  <PropertyGroup>
+    <IsPackable>false</IsPackable>
+  </PropertyGroup>
+</Project>