Add support for more timeouts to Nexus operations - #595
Merged
Merged
Conversation
Quinn-With-Two-Ns
force-pushed
the
SDK-4837
branch
from
February 20, 2026 06:02
ad9e5dc to
815031c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
cretz
reviewed
Feb 20, 2026
Comment on lines
+14
to
+15
| /// Indicates how long the caller is willing to wait for operation completion. | ||
| /// Calls are retried internally by the server. |
Contributor
There was a problem hiding this comment.
Pedantic, but can we move all but the first line of these three docs into a <remarks> section instead?
Contributor
Author
There was a problem hiding this comment.
Done, let me know if it looks right
Contributor
There was a problem hiding this comment.
Remarks should not be nested within summary but be a sibling.
Contributor
Author
There was a problem hiding this comment.
Ah thanks, fixed
cretz
approved these changes
Feb 20, 2026
Contributor
|
LGTM. Merged main and will merge after CI (may be tomorrow) |
This was referenced Mar 19, 2026
Closed
This was referenced Apr 1, 2026
Merged
Closed
This was referenced May 1, 2026
Closed
This was referenced May 15, 2026
This was referenced May 15, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add schedule-to-start and start-to-close for Nexus operations
NOTE, before this can be merged the API still needs to be tagged, core changes need to be merged and tests need to be added
Note
Medium Risk
Touches workflow command construction for Nexus operations; incorrect mapping could change timeout behavior or break compatibility with older servers, though coverage is added via new/updated timeout tests.
Overview
Adds
ScheduleToStartTimeoutandStartToCloseTimeouttoNexusOperationOptionsand wires them throughWorkflowInstance.StartNexusOperationAsyncso Nexus operation scheduling can enforce these server-side timeouts (in addition to the existing schedule-to-close).Extends Nexus worker tests to assert the correct
TimeoutTypesurfaces for schedule-to-close, schedule-to-start, and start-to-close failures, and bumps the local test dev-server download version to pick up the required server support.Written by Cursor Bugbot for commit 94ed30a. This will update automatically on new commits. Configure here.