Update tests and generator to .NET 10 - #562
Merged
Merged
Conversation
jmaeagle99
marked this pull request as ready for review
November 18, 2025 20:01
cretz
reviewed
Nov 18, 2025
cretz
left a comment
cretz
left a comment
Contributor
There was a problem hiding this comment.
Looks great, nothing blocking. But if possible, would like to see that "Build Package" workflow run inside this PR w/ a quick temporary update to confirm it works w/ the new containers/changes.
cretz
approved these changes
Nov 19, 2025
cretz
left a comment
cretz
left a comment
Contributor
There was a problem hiding this comment.
Looks great, merge at will
This was referenced Nov 19, 2025
This was referenced Jan 14, 2026
Bump Temporalio.Extensions.DiagnosticSource from 1.9.0 to 1.10.0
InfinityFlowApp/aspire-temporal#267
Closed
This was referenced Feb 12, 2026
Bump Temporalio.Extensions.DiagnosticSource from 1.9.0 to 1.11.0
InfinityFlowApp/aspire-temporal#277
Closed
This was referenced Feb 19, 2026
Bump Temporalio.Extensions.DiagnosticSource from 1.9.0 to 1.11.1
InfinityFlowApp/aspire-temporal#281
Closed
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Lowest supported .NET version is 8 and both 8 and 9 will be out of support in less than a year at this point. Update to latest LTS (.NET 10) which will be supported for ~3 years.
Checklist
Closes [Feature Request] Consider updating tests to use .NET 10 #522
How was this tested: Local builds and test runs with only .NET 10 SDK installed. Built and ran all projects found to test the SDK tests, smoke test, benchmark, and docfx generation. Checked test counts before and after changes to check that tests were not dropped.
Any docs updates needed? None required. Can consider if the
Task.WhenAny -> Workflow.WhenAnyAsyncrecommendation should be adjusted (as well as the SDK implementation ofWorkflow.WhenAnyAsync) for .NET 8+.