Skip to content

Fix panic on evict w/ buffered tasks #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix panic on evict w/ buffered tasks #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/worker/workflow/workflow_stream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ impl WFStream {
// We accept that there might be query tasks remaining in the buffer if we evicted
// and re-instantiated here. It's likely those tasks are now invalidated anyway.
if maybe_buffered.has_tasks() && should_evict {
panic!("There were leftover buffered tasks");
warn!("There were leftover buffered tasks when evicting run");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm -- you don't need to drain the buffer contents? So these are either going to be treated as valid items, or the buffer is about to be drained anyway, or destroyed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tasks will just get dropped. It's not a meaningful issue for the reason the comment mentions. Worst case the task was valid, and it'll time out and get retried.

}
}
}
Expand Down