Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prettier action on forks, closes #748 #1559

Closed
wants to merge 8 commits into from

Conversation

lorensr
Copy link
Contributor

@lorensr lorensr commented Sep 8, 2022

#748

Trying an edit based on actions/checkout#455 (comment)

@lorensr lorensr requested a review from a team as a code owner September 8, 2022 21:53
@lorensr
Copy link
Contributor Author

lorensr commented Sep 8, 2022

Pausing working on this for now. Things I need to read more about to understand better:

  • why pull_request_target isn't triggering prettier action when i push commits

if no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

@rachfop
Copy link
Contributor

rachfop commented Sep 14, 2022

If we are going to rework prettier - it might be worth looking into dprint.

😎

@lorensr
Copy link
Contributor Author

lorensr commented Sep 17, 2022

@rachfop after the dprint script is done, would you be interested in replacing the prettier action with:

Note the first item in this section:

https://github.com/stefanzweifel/git-auto-commit-action#advanced-uses

@vercel
Copy link

vercel bot commented Oct 6, 2022

@rachfop is attempting to deploy a commit to the Temporal Team on Vercel.

A member of the Team first needs to authorize it.

@lorensr lorensr mentioned this pull request Oct 8, 2022
This was referenced Oct 25, 2022
@rachfop rachfop closed this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants