Fix marshaling of payloads with null values #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
607-json-result-failure
branch
from
e1e9e42
to
1f6d863
Compare
bergundy
approved these changes
Jul 5, 2024
cretz
reviewed
Jul 8, 2024
| replace go.temporal.io/api v1.34.0 => go.temporal.io/api v1.32.1 | ||
| // See https://github.com/temporalio/cli/pull/596#discussion_r1666988960 | ||
| // #596 downgraded api to 1.32.1, but there are required bug fixes that came after 1.32.1. | ||
| replace go.temporal.io/api v1.34.0 => go.temporal.io/api v1.32.1-cherry-pick-for-cli-tag |
There was a problem hiding this comment.
Why are we using a replace clause instead of updating the primary go.temporal.io/api version above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #607
Bump
apito pull in temporalio/api-go#159