Skip to content

Conversation

rodrigozhou
Copy link
Contributor

@rodrigozhou rodrigozhou commented Sep 15, 2025

READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.

What changed?
Update description of Visibility Scan API

Why?
Visibility Scan API has been marked as deprecated since Temporal v1.27.0.
Temporal Server is changing to simply call the List API, so updating the description so it is clear.

Breaking changes

Server PR
temporalio/temporal#8328

@bergundy
Copy link
Member

I don't think we have ever removed a server API, this will in turn break the Go SDK. You should just mark it as deprecated forever IMHO.

@rodrigozhou rodrigozhou force-pushed the rodrigozhou/remove-vis-scan branch 2 times, most recently from 1e53e2a to cb2a40a Compare September 16, 2025 01:21
@rodrigozhou rodrigozhou changed the title Remove Visibility Scan API Remove description of Visibility Scan API Sep 16, 2025
@rodrigozhou
Copy link
Contributor Author

rodrigozhou commented Sep 16, 2025

Ok, in that case, I changed this PR to update the description of the Scan API so it won't be misleading as doing something different than List.

@rodrigozhou rodrigozhou force-pushed the rodrigozhou/remove-vis-scan branch from cb2a40a to 42a3998 Compare September 16, 2025 01:29
@rodrigozhou rodrigozhou changed the title Remove description of Visibility Scan API Update Visibility Scan API Sep 16, 2025
@rodrigozhou rodrigozhou changed the title Update Visibility Scan API Update description of Visibility Scan API Sep 16, 2025
@rodrigozhou rodrigozhou merged commit a09b22e into master Sep 16, 2025
5 checks passed
@rodrigozhou rodrigozhou deleted the rodrigozhou/remove-vis-scan branch September 16, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants