Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi-line templ/script/css function params syntax highlighting #41

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

alehechka
Copy link
Contributor

Overview

This adds more verbose regex patterns to templ and script function begin patterns as well as adds support for multi-line params on each of these function types.

Templ Functions

Before

multi-line-templ-params-broken

After

multi-line-templ-params-fixed

Script Functions

Before

multi-line-script-params-broken

After

multi-line-script-params-fixed

@alehechka
Copy link
Contributor Author

I just pushed a third commit that addresses css functions with params/multi-line params. With this I also refactored the old organization to instead have one large object with nested patterns for the internals of the function to avoid duplicate patterns for css property names.

Before

css-functions-broken

After

css-functions-fixed

@alehechka alehechka changed the title feat: multi-line templ/script function params syntax highlighting feat: multi-line templ/script/css function params syntax highlighting Mar 3, 2024
@joerdav
Copy link
Contributor

joerdav commented Mar 4, 2024

Perfect, thanks for all the support on this!

@joerdav joerdav merged commit ba185d4 into templ-go:main Mar 4, 2024
@alehechka alehechka deleted the multiline-func-syntax branch March 4, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants