Fix: Closing style tags on the same line cause syntax highlight issues #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is the same fix as #35 but for style tags now, as requested by @alehechka.
This PR fixes a syntax highlight issue when closing a style tag on the same line.
The issue is caused because of the .> which matches twice, first were we would expect, after
<style>and then again after<style>...</style>because all>...</styleis captured by .My change seems to fix it without introducing regressions.
Examples of the issue (note the closing of the tags
>)This is how it can mess-up your file if you have more code, even after the closing of the template.
This is how it looks after the fix
