Add svg-as-string mode #5
Conversation
|
Hey! 👋 This is cool idea, I like it and sometimes we've wanted to do the same. How do you feel about exposing the behaviour as a plugin option, rather than a vFile property? Travis isn't happy with the build, I'll take a look at the underlying |
|
Agreed, it'd be better as a plugin option. |
vhf
force-pushed
the
render-svg-as-string
branch
from
a595b9b
to
abc9f74
Compare
|
Done. 😄 |
vhf
force-pushed
the
render-svg-as-string
branch
from
fec4943
to
9259e8a
Compare
| @@ -5,7 +5,6 @@ module.exports = { | |||
| coveragePathIgnorePatterns: [ | |||
| '/node_modules/', | |||
| ], | |||
| mapCoverage: true, | |||
|
@brendo Tests are still passing locally and still failing on Travis, I tried pushing updates for mermaid.cli (latest uses puppeteer 1.x), it didn't help. Any idea? :) |
vhf
force-pushed
the
render-svg-as-string
branch
from
c8a8fd5
to
ab0ed51
Compare
vhf
force-pushed
the
render-svg-as-string
branch
2 times, most recently
from
f0f31a4
to
64bf8fc
Compare
vhf
force-pushed
the
render-svg-as-string
branch
from
64bf8fc
to
8fe9607
Compare
|
Hello @brendo do you have some news about that? |
|
Hey all, any update to this? If not would it be ok if someone picked it up? Wouldn't want to step on toes. |
|
@jimthedev Feel free to take over my initial attempt! |
|
Any updates on this? I don't fully understand how puppeter works, so I'm not really able to pick this up and fix the test. |
There was a problem hiding this comment.
👋 I no longer work at Temando so can't help in terms of merging (@quangkhoa might be able to though?), but I've left a few comments.
| @@ -90,7 +90,7 @@ function replaceLinkWithEmbedded(node, index, parent, vFile) { | |||
| * @param {boolean} isSimple | |||
There was a problem hiding this comment.
Minor, JSDoc update now that this an object that has two possible properties (there's a few other updates needed around this as well).
| @@ -40,6 +41,17 @@ describe('remark-mermaid', () => { | |||
| expect(vfile.messages[0].message).toBe('mermaid code block replaced with graph'); | |||
| }); | |||
|
|
|||
| it('can handle code blocks to svg string', () => { | |||
There was a problem hiding this comment.
I'm curious if the failing test is timing related. If this is pulled up before the previous "can handle code blocks" test, does this one pass and the old test fail?
| @@ -30,15 +30,21 @@ function render(source, destination) { | |||
| // Clean up temporary file | |||
| fs.removeSync(mmdPath); | |||
|
|
|||
| if (asString) { | |||
| const string = fs.readFileSync(svgPath, { encoding: 'utf-8' }); | |||
| fs.removeSync(svgPath); | |||
There was a problem hiding this comment.
I wonder if this is the cause of the test errors 🤔
|
Thank you for still helping on a project you don't own anymore ❤ |
|
https://travis-ci.org/yuku/remark-mermaid/builds/493032690 EDIT: I simply pushed after checking out this branch. I changed nothing. |
|
Why was this PR closed? From the comments I understand this PR would work if CI was triggered. I’m still interested in this feature. If this PR needs more changes, please give some feedback. |
|
@remcohaszing It's been 16 months since I opened this and I gave up, feel free to take over: #5 (comment) if you wish to push this forward, at this point I don't. :) |
Here is a suggestion, I'd love some feedback.
Motivation: in some situations I'd rather output the SVG directly instead of serving it as an asset.