Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update versions #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sebhoerl
Copy link

@sebhoerl sebhoerl commented Sep 1, 2024

I'm using bhepop2 in a project together with biogeme, which requires some versions to be more recent than the fixed ones here. I updated the versions and run the tests, this seems to work.

@leo-desbureaux-tellae
Copy link
Contributor

leo-desbureaux-tellae commented Sep 2, 2024

Hello @sebhoerl ! Nice to see you using bhepop2, hope its works as you want !
Regarding the project requirements: i initially developed the package with more recent versions, in particular for numpy and pandas. But Eqasim uses older versions (tell me if i'm wrong), so i matched the eqasim versions to avoid conflicts.

  - pandas=1.5.3
  - numpy=1.23.5

Should we work instead write

numpy>=1.23.5
pandas>=1.5.3
xlrd>=2.0.1
scipy>=1.10.1
scikit-learn>=1.2.2
plotly>=?

I'm not entirely sure it is the right thing to do, tell me if you have ideas

@sebhoerl
Copy link
Author

sebhoerl commented Sep 2, 2024

Also not sure from my side, but I would say we should update eqasim soon. For now, we have bhepop2==2.0.0 as a dependency, so this will stay without a problem. And as soon we update the versions in eqasim we could just link to the new release of bhepop2 I would say.

@leo-desbureaux-tellae
Copy link
Contributor

leo-desbureaux-tellae commented Sep 2, 2024

Ok, this seems good to me, didn't think about the fixed version in Eqasim. If you say you'll update Eqasim soon this should be fine.

We just need to update the python version used to run the tests, as numpy 2.1 needs python >= 3.10.
It's this part in .github/workflows/tests.yml:

      - uses: actions/setup-python@v4
        with:
          python-version: '3.10'

I don't know how i can contribute to this branch, i'm not used to work with forks.

@leo-desbureaux-tellae
Copy link
Contributor

leo-desbureaux-tellae commented Sep 2, 2024

And also update the setup.py by:

  • removing the "Programming Language :: Python :: 3.9" classifier
  • updating the python_requires param to ">=3.10"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants