feat!: eqasim integration fixes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leo-desbureaux-tellae
commented
Mar 26, 2024
•
leo-desbureaux-tellae
commented
- change requirements to match those of Eqasim
- improve validation logic
- add bhepop2 specific exceptions: PopulationValidationError and SourceValidationError
- moved some validation functions in relevant classes
- added a new method usable_with_population to EnrichmentSource class, for testing compatibility with a population
- added a new class attribute _required_source_class to SyntheticPopulationEnrichment class, used to test the source instance class
- added missing validation tests
- remove useless function read_filosofi_excel
- remove some pandas warnings
leo-desbureaux-tellae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.